jensb89
commented
2 years ago Thanks for the input. Multiple wallet support is actually a good idea, but I think the problem of the wrong yield could also be dealt with in another way.
Let me try to explain:
The code that calculates the single yield value at the top of the webpage is the following:
for d in deposits:
r = d["Out"]/d["In"]
aUstAmount += d["In"]
# Yield
y = (currentaUstRate - r) * d["In"] if d["Out"]!=0 else 0 #todo: calculate right rate for aUST transfersWhat is done here: Each time a user deposits UST, the UST amount is burned and an amount of aUST is minted. From this we can calculate an exact rate aUST to UST by diving the two (r in the above code). Also from the Anchor contract we can query the exact aUST rate at this very moment. The yield is then simply: (the rate right now minus the rate at the time of the deposit) times the aUST amount. (for redemption the same way, just with a - sign)
For the aUST transfer we don't have these information, which is why I set the yield from that to 0 for now and which is also why you still see it in your old account.
The proper way to handle it in my opinion would be: y = (currentRate - aUSTRateAtTransferTime) * aUSTAmountOfTransfer This means, at the time of the transfer the yield would be 0 and from there it would constantly grow.
The big problem: There is no historical information of the exact aUST rate, at least I couldn't find a way to query it from the contract or the Terra API :(
What we could do:
- Use historical aUST rate data from flipsidecrypto database calls (downside: not exact numbers or a lot of output values are needed, slowing down the webapp even more + relying on the the external provider)
- Trying to grab a random anchor UST deposit transaction from the terra API, at best at the same block height / same time as the aUST transfer and calculate the aUST rate from there. Downside: Requires more http requests and code to handle it all :(
Thus, the only problem actually is to get the aUST to UST rate at the time of the aUST transfer. I don't really like both of these options, but for starters I could try to get the value from the historical data that is alraeady used to calculate the plot in the webapp. This data is also from flipsidecrypto but only has 1 datapoint per day, so it is not that accurate as of now...
Would be much easier if Anchor would allow us to query historical rates ...
wtanksleyjr
omer411
Although handling aUST transfers is hard, I note that you're actually doing it correctly: specifically, if the user transferred from an old account to a new one, they'll be credited correctly for all of the interest on both, but only if you add the two accounts together.
Since I suspect most users won't transfer aUST to someone else's account (personally, I did it after I'd bought a Ledger Nano), it's very likely that users with this problem will want to track all of their accounts. So the way you're doing it actually works for me; in my case, my original account (with almost no aUST left) shows almost all of my actual interest earned (because that's where I bought almost all of the aUST), and my second account shows almost nothing (because I made only minor deposits there). As an accidentally nice result, this means I can get an almost-right answer by simply viewing my original account, but in general I can get as exact as I want by adding the two amounts together (and realistically, I'll have to do that in the future).
This in turn suggests an "easy fix" (no doubt it's harder than it sounds) of allowing multiple wallets to be added.