search

jensechu / kanji

Customizable Kanji character charts that are easily printable to help practice writing.
http://jensechu.github.io/kanji/
183 stars 34 forks source link

WaniKani sync doesn't seem to work #25

Open SavannahJohnston opened 3 years ago

SavannahJohnston commented 3 years ago

I pasted in my API token and clicked "sync", but nothing happened.

h1-yena commented 3 years ago

The server responds with a 410 Gone, which is probably because the API changed and has to yet been updated.

invpt commented 3 years ago

You can use my fork at https://xelaushi.github.io/kanji/ (repo https://github.com/xelaushi/kanji), though it's been rewritten in TypeScript so that I can maintain it myself; no possibility of merging it here.

jensechu commented 3 years ago

@xelaushi Hello! You're welcome to submit a PR to merge into this repo with TypeScript. The only reason I don't maintain this one much is because I was in the middle of a rewrite then moved on to other things. I'd be happy to have the help and I love TS. 😄

jensechu commented 3 years ago

If not then I will just go ahead and patch this so we can get around the issue for now.

invpt commented 3 years ago

I'll submit one then! I initially thought a full-on rewrite might be a lot for a PR, but I'll be glad to have it merged.