search

jenseng / react-i18nliner

translate="yes" all the things
MIT License
45 stars 15 forks source link

Fix build on Windows #29

Closed Download closed 7 years ago

Download commented 7 years ago

Removed the node_modules prefix when calling eslint and jest They are not needed since these libraries are NPM dependencies and NPM knows how to invoke them See Running tests fails on Windows #28

After applying the changes from this PR, I get this result for npm test:

c:\ws\react-i18nliner> npm test

> react-i18nliner@0.1.0 test c:\ws\react-i18nliner
> eslint . && jest

Using Jest CLI v12.1.1, jasmine2, babel-jest
Running 2 test suites...
 PASS  __tests__\ComponentInterpolator.test.js (1.433s)
 PASS  __tests__\preprocess.test.js (1.598s)
29 tests passed (29 total in 2 test suites, run time 3.393s)
jenseng commented 7 years ago

👍 thanks for this, sorry for the slow turnaround ... just now getting back to this repo to update some things :)

Download commented 7 years ago

No worries, I know how these things go (I do it myself all the time).

Thanks for merging it! 👍