search

jensengroup / propka

PROPKA predicts the pKa values of ionizable groups in proteins and protein-ligand complexes based in the 3D structure.
http://propka.org
GNU Lesser General Public License v2.1
258 stars 58 forks source link

Update strings to be more pythonic - use f-strings #104

Closed intendo closed 2 years ago

intendo commented 3 years ago

Update all strings to use f-strings rather than using str.format syntax

sobolevnrm commented 3 years ago

@speleo3 @orbeckst -- I think one of you suggested this before. Do you concur?

IAlibay commented 3 years ago

Probably worth mentioning this, some very small parts of the codebase now use f-strings as of #85 and #84.

May I suggest taking a strategy where type hinting & f-strings are added progressively as API docs are completed (say for something like #98)?

speleo3 commented 3 years ago

I like f-strings and certainly use them in new code when possible. But updating existing code with a new pattern is usually low priory for me and it comes with an inherit risk for regressions.

intendo commented 2 years ago

Closing issue due to lack of progress and I agree with @speleo3 and @IAlibay that this can be done incrementally over time.