search

jensengroup / propka

PROPKA predicts the pKa values of ionizable groups in proteins and protein-ligand complexes based in the 3D structure.
http://propka.org
GNU Lesser General Public License v2.1
256 stars 58 forks source link

Return context manager from open_file_for_reading #133

Closed speleo3 closed 2 years ago

speleo3 commented 2 years ago

Ensures that file handles will be closed.

Alternative to https://github.com/jensengroup/propka/pull/132

/cc @stefdoerr

codecov[bot] commented 2 years ago

Codecov Report

Merging #133 (ed087b0) into master (68007f0) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   73.05%   73.07%   +0.02%     
==========================================
  Files          24       25       +1     
  Lines        3963     3967       +4     
==========================================
+ Hits         2895     2899       +4     
  Misses       1068     1068
Impacted Files Coverage Δ
propka/input.py 96.15% <100.00%> (ø)
propka/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68007f0...ed087b0. Read the comment docs.