jensengroup / propka

PROPKA predicts the pKa values of ionizable groups in proteins and protein-ligand complexes based in the 3D structure.
http://propka.org
GNU Lesser General Public License v2.1
256 stars 58 forks source link

Update versioneer to version 0.29 #171

Closed speleo3 closed 10 months ago

speleo3 commented 10 months ago

Installed versioneer 0.29 with Python 3.12 and ran

versioneer install

Fixes the following error when doing pip install . with Python 3.12:

  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      propka/versioneer.py:421: SyntaxWarning: invalid escape sequence '\s'
        LONG_VERSION_PY['git'] = '''
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "propka/setup.py", line 10, in <module>
          version=versioneer.get_version(),
                  ^^^^^^^^^^^^^^^^^^^^^^^^
        File "propka/versioneer.py", line 1480, in get_version
          return get_versions()["version"]
                 ^^^^^^^^^^^^^^
        File "propka/versioneer.py", line 1412, in get_versions
          cfg = get_config_from_root(root)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "propka/versioneer.py", line 344, in get_config_from_root
          parser.readfp(f)
          ^^^^^^^^^^^^^
      AttributeError: 'ConfigParser' object has no attribute 'readfp'. Did you mean: 'read'?
      [end of output]
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (33158d1) 73.05% compared to head (1e5a8c9) 73.09%. Report is 2 commits behind head on master.

:exclamation: Current head 1e5a8c9 differs from pull request most recent head a03d903. Consider uploading reports for the commit a03d903 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #171 +/- ## ========================================== + Coverage 73.05% 73.09% +0.04% ========================================== Files 25 25 Lines 3989 3988 -1 ========================================== + Hits 2914 2915 +1 + Misses 1075 1073 -2 ``` | [Files](https://app.codecov.io/gh/jensengroup/propka/pull/171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jensengroup) | Coverage Δ | | |---|---|---| | [propka/\_\_init\_\_.py](https://app.codecov.io/gh/jensengroup/propka/pull/171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jensengroup#diff-cHJvcGthL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jensengroup/propka/pull/171/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jensengroup)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

speleo3 commented 10 months ago

Would it be worth also bumping up to include 3.12?

Yes, good catch.