search

jensengroup / propka

PROPKA predicts the pKa values of ionizable groups in proteins and protein-ligand complexes based in the 3D structure.
http://propka.org
GNU Lesser General Public License v2.1
256 stars 58 forks source link

Fix problem with ZIP paths on Windows. #182

Closed sobolevnrm closed 8 months ago

sobolevnrm commented 8 months ago

Fixes #181.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5a00d05) 74.82% compared to head (8659f03) 74.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #182 +/- ## ========================================== + Coverage 74.82% 74.84% +0.01% ========================================== Files 25 25 Lines 4116 4118 +2 ========================================== + Hits 3080 3082 +2 Misses 1036 1036 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

speleo3 commented 8 months ago

Thanks for the fix! There is a method for getting the string with forward slashes: Path.as_posix() Result should be the same, but maybe looks a bit cleaner?

https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.as_posix

sobolevnrm commented 8 months ago

@speleo3 can you please review again with this change?