jensengroup / propka

PROPKA predicts the pKa values of ionizable groups in proteins and protein-ligand complexes based in the 3D structure.
http://propka.org
GNU Lesser General Public License v2.1
256 stars 58 forks source link

Remove unused code #187

Closed speleo3 closed 6 months ago

speleo3 commented 6 months ago

Attention: This is rigorous cleanup! I removed code which appears to be broken, unused or unreachable within the code base. I cannot rule out that anything of that is used from external code, although I believe that it's very unlikely.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6ee0df8) 74.84% compared to head (25ed65e) 77.45%.

Files Patch % Lines
propka/lib.py 75.00% 1 Missing :warning:
propka/parameters.py 96.66% 1 Missing :warning:
propka/version.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #187 +/- ## ========================================== + Coverage 74.84% 77.45% +2.61% ========================================== Files 25 25 Lines 4118 3952 -166 ========================================== - Hits 3082 3061 -21 + Misses 1036 891 -145 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

speleo3 commented 6 months ago

Sorry, I don't have the bandwidth for a real review. I only had a very quick look at the changes and the coverage changes. The fact that code was removed that was not covered by tests is good. Overall I like the streamlining. Thanks for doing all the work!

Thanks for having a look and thanks for your support!