Closed IAlibay closed 4 years ago
Merging #85 into master will increase coverage by
1.89%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 70.41% 72.30% +1.89%
==========================================
Files 25 25
Lines 4140 4127 -13
==========================================
+ Hits 2915 2984 +69
+ Misses 1225 1143 -82
Impacted Files | Coverage Δ | |
---|---|---|
propka/input.py | 62.65% <ø> (-0.23%) |
:arrow_down: |
propka/run.py | 68.57% <100.00%> (+68.57%) |
:arrow_up: |
propka/ligand_pka_values.py | 20.28% <0.00%> (-2.25%) |
:arrow_down: |
propka/coupled_groups.py | 75.48% <0.00%> (-0.47%) |
:arrow_down: |
propka/vector_algebra.py | 58.15% <0.00%> (-0.45%) |
:arrow_down: |
propka/bonds.py | 60.48% <0.00%> (-0.32%) |
:arrow_down: |
propka/version.py | 63.15% <0.00%> (-0.28%) |
:arrow_down: |
propka/protonate.py | 88.42% <0.00%> (-0.18%) |
:arrow_down: |
propka/conformation_container.py | 83.40% <0.00%> (-0.15%) |
:arrow_down: |
propka/group.py | 76.38% <0.00%> (+1.71%) |
:arrow_up: |
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d16257a...d639256. Read the comment docs.
Also, awesome test coverage... isn't it nice when one commit increases overall coverage by 2%!
Fixes #82
Changes:
read_molecule_file
in #84test_run
file specific for testingrun
.Notes:
test_run
overlap a lot withtest_streamio
, strictly speaking I could probably ditch part oftest_streamio
as it's implicitly tested. However in some ways it might be good to have the two run in parallel to make sure that some change in run.single isn't introducing new behaviour. Either way would work, but it might not be that big a deal with the tests running as fast as they currently do?To do: