jensengroup / propka

PROPKA predicts the pKa values of ionizable groups in proteins and protein-ligand complexes based in the 3D structure.
http://propka.org
GNU Lesser General Public License v2.1
258 stars 58 forks source link

Report correct version in .pka file header #92

Closed speleo3 closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #92 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   72.39%   72.40%           
=======================================
  Files          24       24           
  Lines        4141     4142    +1     
=======================================
+ Hits         2998     2999    +1     
  Misses       1143     1143           
Impacted Files Coverage Δ
propka/output.py 61.71% <100.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb65c64...79b6eab. Read the comment docs.

speleo3 commented 4 years ago

I assume that there are no other parts of the code where we hard-coded the version?

I grepped through the code for "3.2" and didn't find anything else (except example output in the docs).

sobolevnrm commented 4 years ago

I assume that there are no other parts of the code where we hard-coded the version?

I grepped through the code for "3.2" and didn't find anything else (except example output in the docs).

I hope not... sorry I missed this earlier.