search

jenskutilek / FiraSystemFontReplacement

Modified version of the Fira Sans fonts to replace the default system font on macOS
750 stars 23 forks source link

Adding a one-line installation command. #24

Closed waltfy closed 9 years ago

waltfy commented 9 years ago

I'm sure it can be done in a better way, but it's a start.

vitorgalvao commented 9 years ago

Options line curl’s -# are a matter of preference and shouldn’ be included in this type of instructions (--silent, however, might be useful). The amount of && should also be reduced to a minimum; when you have so many it’s no longer a one-liner, might as well use a script. There’s also no need to save the file, delete it, and stuff like that; places like /tmp work great for such disposable files. You should also not simply log out a user out of the blue without a lot of warnings and an option to cancel. curl 'http://www.kutilek.de/download/fira-system-fonts.zip' | tar -xf- -C /tmp && mv /tmp/Fira System Fonts/*ttf /Library/Fonts will work just as well (without the logging out).

waltfy commented 9 years ago

@vitorgalvao I see, your suggestions make a lot of sense. With /tmp so should I just leave the disposable files there?

Thanks a lot.

vitorgalvao commented 9 years ago

Yes, the system will figure out when to get rid of them (likely on the next boot up).

waltfy commented 9 years ago

Cool. Thanks again!

rauberdaniel commented 9 years ago

As the command won’t log you out anymore, you should fix the description.

waltfy commented 9 years ago

@rauberdaniel Of course. Thanks. Fixed.

jenskutilek commented 9 years ago

I have added an installer package to install the font into the correct folder and to force a restart.