search

jensl / critic

Critic code review system.
Other
385 stars 58 forks source link

Unacceptable use of system resources #23

Open treyhunner opened 12 years ago

treyhunner commented 12 years ago

I installed critic out of curiosity and I've had the following problems with my computer since:

  1. Dozens of watchdog processes run in the background
  2. I sometimes receive hundreds of email every minute warning me that a file was created X seconds ago
  3. Sometimes dozens of sendmail processes in the background (probably related to 2)
  4. Occasionally high CPU usage
  5. Eventually 100% RAM and swap usage (either from a memory leak or the dozens of backgrounded processes that may be multiplying)
  6. Just hit 100% disk usage from /var/log/mail.log, /var/log/mail.info, and /var/log/syslog

These problems are most likely due to an incorrect configuration. I am planning on uninstalling critic as soon as I can figure out how because I actually have no use for it currently (I only installed it to try it out).

jensl commented 12 years ago

Ouch, I'm very sorry you ran into those problems!

I don't recognize the symptoms, but it I guess it might all be because of problems delivering mails. Mail delivery currently assumes there's an SMTP server running at localhost:25 (the installation script should query for that information.) Mail delivery problems are also reported to the "system administrator" via mails, which is typically not very meaningful and could, I guess, lead to runaway mail generation in unfortunate circumstances. (This error reporting via mails is generic, so what's missing is an exception for mail delivery errors.)

I'll will look into improving this.

Again, I'm very sorry for the inconvenience this caused you.

treyhunner commented 12 years ago

Let me know if there are specific config/log files that might be useful for me to send you privately (in case they have personal information). I truncated all the huge log files, but there's some lines in each left.

jensl commented 12 years ago

Critic's log files under /var/log/critic/main/ would be of some interest, in particular servicemanager.log, watchdog.log and maildelivery.log. If you still have them, it'd be great if you could email them to me at jl@sloth.whyi.org.