search

jenslind / electron-gh-releases

:shipit: Electron auto-update by releasing on Github.
MIT License
225 stars 14 forks source link

Linux #21

Closed bayleedev closed 8 years ago

bayleedev commented 8 years ago

When you call check on the API it returns an exception if they aren't window/mac.

https://github.com/jenslind/electron-gh-releases/blob/master/src/GhReleases.js#L105-L106

Is it possible to to still check if an update is available, but have download do this check? That way I can alert the users "there IS an update, but you need to download it manually" instead of "you don't support updates, and I'm not sure if there is one" ?

jenslind commented 8 years ago

👍

I think the easiest would be to move the platform check here (before setFeedURL) And then return the error and status can still be true.