jensrossbach / node-red-contrib-chronos

Time-based Node-RED scheduling, repeating, queueing, routing, filtering and manipulating nodes
https://jensrossbach.github.io/node-red-contrib-chronos
MIT License
28 stars 1 forks source link

No any time works in Repeat node / until settings if the time will be valid on next day #145

Closed Smyl3 closed 3 months ago

Smyl3 commented 3 months ago

Describe the bug For repeat node at 'until' option no any time in future works that will be valid only on the next day.

To reproduce Steps to reproduce the behavior:

  1. set a timestamp node and connect it to a chronos-repeat node.
  2. Go to 'config Repeat node'
  3. set any time at 'until' option that will be valid on the next day
  4. click to initiate a timestamp
  5. See that nothing happens, no any new time showed at node status with the next trigger time

Expected behavior Expecting to work with any time that will be on next day.

Context information

jensrossbach commented 3 months ago

Yes, I can confirm the bug.

jensrossbach commented 3 months ago

Issue has been fixed with release 1.22.

Smyl3 commented 3 months ago

For some reason in node-red (docker) I still see only version 1.22.0 of node, not 1.22.1 as on npm and node-red website....

jensrossbach commented 3 months ago

I don't why that is the case, I don't use Node-RED in a docker container. Maybe you need to wait a bit for it to appear.

Anyway, I strongly recomment to use v1.22.1 instead of 1.22.0 as there was a regression in 1.22.0 introduced (this happened because moment.js introduced a stricter parsing with version 2.30.0 and I tested all the time with an older version, so I didn't notice this).

Smyl3 commented 3 months ago

It allowed me to update to 1.22.0 only, but does still not show version 1.22.1 Tried restart container etc, nothing worked so far. Tried to use npm command either without any success. Weird.

Smyl3 commented 3 months ago

All right, it seems I could update the module, but needed a tricky manual method, from inside container.

docker exec -it nodered /bin/bash
cd /data/node_modules/
/data/node_modules$ npm list
/data/node_modules$ npm update

Thank you the fast update.