search

jenssegers / agent

👮 A PHP desktop/mobile user agent parser with support for Laravel, based on Mobiledetect
https://jenssegers.com
MIT License
4.48k stars 472 forks source link

laravel 8 support? #178

Open yaowei520 opened 3 years ago

mfn commented 3 years ago

@yaowei520 is there anything specifically not working?

The package provides a Laravel service provider but besides that has no e.g. version constraints, see https://github.com/jenssegers/agent/blob/1bacac5ab1cb415792bb74620e66a954ea740816/composer.json#L13-L21

jason-klein commented 3 years ago

I successfully installed your package into a Laravel 8 application without any modifications.

I expected a conflict since your package requests PHPUnit 5/6/7, but Laravel 8 uses PHPUnit 9. Just FYI in case OP can confirm they are receiving a PHPUnit conflict during install. The PHPUnit 9 requirement is listed in the Laravel 8 Upgrade Guide and in the Laravel 8 composer file.

https://github.com/laravel/laravel/blob/c6c41f11b8ea3065f035fbb6a6f570b7bfba0037/composer.json#L18-L24

jangaraev commented 2 years ago

Confirm that it works on L8 project absolutely well.