jenssegers / agent

👮 A PHP desktop/mobile user agent parser with support for Laravel, based on Mobiledetect
https://jenssegers.com
MIT License
4.48k stars 472 forks source link

Fixed incompatibility with Mobile-Detect v2.8.43 #209

Open sunnydavis opened 8 months ago

sunnydavis commented 8 months ago

The problem is caused by the ->is*() function, aka the "Extended" features confusing the core function of detecting mobile devices. I think the better way to fix it is to overwrite the getMobileDetectionRules() and make sure it won't be polluted. In this case the extended features still work while not sacrifice the ability to detect mobile devices.

francislavoie commented 8 months ago

No longer needed, see https://github.com/jenssegers/agent/pull/208#issuecomment-1800260630