search

jenssegers / laravel-rollbar

Rollbar error monitoring integration for Laravel projects
328 stars 98 forks source link

Change to long array syntax #20

Closed ockle closed 8 years ago

ockle commented 9 years ago

The package does not currently work on PHP 5.3 as the composer.json indicates it should. This changes a usage of short array syntax.

osaris commented 9 years ago

PHP 5.3 is EOL since more than one year so I'm not sure it's a good idea to rollback (source http://php.net/supported-versions.php)

ockle commented 9 years ago

@osaris While I agree with you on PHP 5.3 support in principle, this package's composer.json has:

"require": {
  "php": ">=5.3",
   ...
}

So this pull request makes the package adhere to that.

osaris commented 9 years ago

@okcle right, so why not make a PR to update the composer.json instead :) ?

ockle commented 9 years ago

@osaris Because there's only this one, easily changed piece of code that is stopping this package from working on 5.3 as advertised. And seeing as there's nothing else in it that requires >= 5.4, it seems that the least disruptive, most user-friendly solution is to just change the array syntax. Also, I personally think it's up to package authors to decide what version of PHP their package supports and for contributors to help ensure that it does :)

jenssegers commented 9 years ago

I'm all up for ditching 5.3. Can you fix the travis and composer file as well? I'll merge the PR and tag a new major or minor version :)