jenssegers / laravel-rollbar

Rollbar error monitoring integration for Laravel projects
329 stars 99 forks source link

Adds Lumen 5.x support #54

Open GiamPy5 opened 8 years ago

GiamPy5 commented 8 years ago

Adds Lumen 5.x support by using Monolog\RollbarHandler.

GiamPy5 commented 8 years ago

StyleCI analysis has been fixed, it shows as failed because I have used a soft reset to squash the commits. @jenssegers

jenssegers commented 8 years ago

Wouldn't it be better to refactor the original service provider so that the Lumen service provider can extend it and only override Lumen specific stuff?

This way there is less code duplication.

GiamPy5 commented 8 years ago

@jenssegers That's actually a good idea, I'll work on that instead.

earnaway commented 8 years ago

Any update on this PR or your code changes @GiampaoloFalqui? Thanks.

nickfan commented 8 years ago

since it's been a while,i created my PR #60 for this as @jenssegers asked.

earnaway commented 8 years ago

Thanks for the update @nickfan - I do notice that all the checks failed on that PR in StyleCI and Travis CI - @jenssegers might not be able to merge that in.

nickfan commented 8 years ago

@earnaway i have rewrite the code #60 for the check , it passed StyleCI and travis-ci, but coverage/coveralls Coverage decreased (-9.9%) to 65.116% ,is that ok for merge?

earnaway commented 8 years ago

I guess we'll have to wait for @jenssegers to look over it and hopefully merge that into master.

bkuhl commented 8 years ago

Any updates on this? It'd be really nice to have Lumen support as there aren't any other packages that do this ATM.

GiamPy5 commented 8 years ago

I am very sorry about the huge await, I have improved the Pull Request by using Inheritance. @jenssegers feel free to give a look.

bkuhl commented 8 years ago

Looks like we're unable to merge due to unresolved conflicts, can you look at those?

GiamPy5 commented 8 years ago

@bkuhl Done!

GiamPy5 commented 8 years ago

Any news?

bkuhl commented 7 years ago

The build is still failing

jasonroman commented 7 years ago

Has anyone taken a look at this in awhile?

GiamPy5 commented 7 years ago

Build fixed and code updated with the latest master changes!

RudyJessop commented 7 years ago

Lumen support is desperately needed. Looking at the committed files I don't see a completed test case for src/RollbarLumenServiceProvider.php. Thats why coveralls coverage is decreasing/failing

GiamPy5 commented 7 years ago

There isn't a way to test the LumenServiceProvider, it only exists for Laravel unfortunately.

jelhan commented 7 years ago

@jenssegers Is there any chance this PR is merged even if RollbarLumenServiceProvider is not covered by tests? If not: Would you accept a dirty work-a-round to get it tested or is this one blocked by orchestra/testbench not supporting lumen? Please note that crynobone said that adding lumen support to orchestra/testbench might be possible for lumen >= 5.2 but as far as I know nobody is working on it yet.

wjgilmore commented 7 years ago

FWIW this morning I followed this tutorial to create a custom service provider in order to use this package with a Lumen 5.2 project, and it worked like a charm:

https://recursionrecursion.co.uk/post/integrating-rollbar-with-lumen

khoivm commented 6 years ago

Hi all, any news for this? I know we can do the custom service provider, but it is best to have it on the package.

chukkynze commented 5 years ago

@wjgilmore I tried that tutorial for Lumen 5.7 and it uses deprecated methods and of course fails. If James Elliot would update it for Lumen 5.7 it could make lives easier but for now, it doesn't work for the current version of Lumen