jenssegers / laravel-rollbar

Rollbar error monitoring integration for Laravel projects
329 stars 99 forks source link

Indicating the service provider is loaded when app is booting #78

Closed bkuhl closed 7 years ago

bkuhl commented 7 years ago

This PR attempts to make it clear that this portion of the configuration belongs in boot() and not register()

drbyte commented 7 years ago

Hmmm ... Registering of service providers is normally done in register().

boot() is for triggering its features (configuring, initializing, instantiating related objects, etc) after it's been registered.

bkuhl commented 7 years ago

Got it. This has been updated