search

jensvh / litematica-printer

Creative Commons Zero v1.0 Universal
8 stars 2 forks source link

implement accurateBlockPlacement code #5

Closed aria1th closed 3 years ago

aria1th commented 3 years ago

tested in creative, seems to work good should change player-side to arbitary side if available, it uses player facing direction at default

aria1th commented 3 years ago

Wait until I fix masa's original bug pls

aria1th commented 3 years ago

Fixed now

jensvh commented 3 years ago

Sounds great, but could you give me a quick explanation of what is does? And what the CarpetProtocol is? I gave it a go with the release on your fork, but it seems the rotation of comparators/repeaters and stairs isn't working as expected.

aria1th commented 3 years ago

I fixed that recently : carpet protocol uses invaild X to code its state. but due to original masa's code error, it was miscoded and easyplace itself used to be faulty : comparator / repeater was rotated when it has different delay. https://github.com/gnembon/carpet-extra/blob/master/src/main/java/carpetextra/utils/BlockPlacer.java

I found that it was using 16 instead of 32, and fixed it.(also delay too), so now it places block with state, don't have to click more times. maybe I released wrong one?

jensvh commented 3 years ago

If you can confirm that it works, its fine for me and I'll merge it.

aria1th commented 3 years ago

https://user-images.githubusercontent.com/35677394/129720357-00cc1aa4-90b1-4afd-bd57-9b6b36f1d6e5.mp4

Here is a video that how it works it needs 'accurateblockplacement' in carpet extra / quickcarpet to work properly, so default is set to off

aria1th commented 3 years ago

but I guess it might not work properly with hoppers, so maybe should be fixed once more...

jensvh commented 3 years ago

For some reason I can only hear audio, but its good enough.