search

jensweigele / ioBroker.yahka

Yet another HomeKit adapter for ioBroker
MIT License
132 stars 47 forks source link

Add AVAHI advertiser as default #350

Closed TA2k closed 1 year ago

TA2k commented 2 years ago

Add AVAHI advertiser as default advertiser. Supported since hap-nodejs 0.10 If not AVAHI advertiser is available hap-nodejs fallback to ciao

Apollon77 commented 2 years ago

LGTM @jensweigele @GermanBluefox please accept and release

jensweigele commented 2 years ago

Thanks for submitting that PR! Can you please undo all the formatting changes? That makes it much easier to review the changes.

TA2k commented 2 years ago

Here is the last functional commit without formatting https://github.com/jensweigele/ioBroker.yahka/pull/350/commits/ad8e3b6a0d64db22b00be9a4fdaca822ee7933ec

or all commits after formatting https://github.com/jensweigele/ioBroker.yahka/pull/350/files/b0ebb36e25555bf5882cd2f4b9e65c8a1fe183b8..ad8e3b6a0d64db22b00be9a4fdaca822ee7933ec

TA2k commented 2 years ago

@jensweigele can you have a look again on the PR

TA2k commented 2 years ago

@GermanBluefox Can you please have a look and release a new version

jensweigele commented 1 year ago

I reverted the push since it looks like it broke the software (see #359)

jensweigele commented 1 year ago

Just saw that someone also published that broken version to NPM - I'm going to release a 0.16 to revert the changes...