misc fixes - Githubissues

jentrata / jentrata-msh

Jentrata - Message Handler Service

jentrara.org

Other

19 stars 57 forks source link

misc fixes #10

Closed EdwinVDS closed 8 years ago

EdwinVDS commented 8 years ago

fix handling of failed asynch acknowledgement
added import of CanReceive in CPA
fixed incorrect propertyref in as2 jdbc props
bugfix in reporting of imported profiles

aaronwalker commented 8 years ago

Hi Edwin

thanks for the pull requests :+1:

Some feedback on this PR is it needs to be broken into multiple ones for each separate fix.

Best to create separate branches, one for each fix and submit PR from those branches and not from master. best practice is generally not to do submit PR from master branch.

It makes it easier for me to manually test each change in isolation

again thanks for your contributions

EdwinVDS commented 8 years ago

Hi Aaron, no problem. I have just created 3 PRs on for the 3 fixes, each on their own branch