Closed EdwinVDS closed 8 years ago
Hi Edwin
thanks for the pull requests :+1:
Some feedback on this PR is it needs to be broken into multiple ones for each separate fix.
Best to create separate branches, one for each fix and submit PR from those branches and not from master. best practice is generally not to do submit PR from master branch.
It makes it easier for me to manually test each change in isolation
again thanks for your contributions
Hi Aaron, no problem. I have just created 3 PRs on for the 3 fixes, each on their own branch