search

jentrata / jentrata-msh

Jentrata - Message Handler Service
jentrara.org
Other
19 stars 57 forks source link

Remove DuplicateElimination from Acknowledgement #32

Closed cavycorp closed 7 years ago

cavycorp commented 7 years ago

In the ebMS 2.0 standard it is not allowed to have a DuplicateElimination indicator in the Acknowledgement message. This change will update the method generateAcknowledgment by removing the lines that will add the DuplicateElimination indicator.

base2bot commented 7 years ago

Can one of the admins verify this patch?

cavycorp commented 7 years ago

Actually a change I've added before and took out afterwards. But checking the ebMS 2.0 standard the DuplicateElimination parameter is not and can not be part of an Acknowledgement message.

Most of the ebMS 2.0 implementations simple ignore this parameter, however there are implementations which are following the standard very close and therefore don't accept an Acknowledgement message with a DuplicateElimination parameter in it.

According to the ebMS 2.0 standard there is no reason for any ebMS 2.0 implementation to reject an Acknowledgement without a DuplicateElimination parameter.

Jentrata in our environment is exchanging messages with many ebMS 2.0 implementations none of them is sending the DuplicateElimination parameter as part of the Acknowledgement message.

aaronwalker commented 7 years ago

closing no longer valid