search

jentrata / jentrata-msh

Jentrata - Message Handler Service
jentrara.org
Other
19 stars 57 forks source link

Make partnershipId more unique #49

Open hollabalo opened 6 years ago

hollabalo commented 6 years ago

This adds the serviceName as part of the partnershipId generated when importing CPA. Sometimes, some partnerships end up with the same generated partnershipId.

This will prevent missing partnerships from the CPA import.

base2bot commented 6 years ago

Can one of the admins verify this patch?

aaronwalker commented 6 years ago

@jmgerona so the problem your having is you have CPA agreements with same CPAId, channel and action?

Good CPA design should generally make action unique per channel and in most cases action unique within the CPA.

I don't have an issue introducing this change will just need to do some testing to verify it doesn't introduce any side affects, which I better sure it should be fine

hollabalo commented 6 years ago

@aaronwalker Yes, that is the problem that we are having. Also, the CPA is from an actual telco that we are working with now.

At first, we were wondering why we don't get all the partnerships when we import the CPA file. Then we found this, thus making the change.