search

jentrata / jentrata-msh

Jentrata - Message Handler Service
jentrara.org
Other
19 stars 57 forks source link

Fix for Failed asynch acknowledgements handled incorrectly #8 #54

Closed cavycorp closed 5 years ago

cavycorp commented 5 years ago

The changes made in this request will correct the behaviour of Jentrata concerning re-sends of Acknowledgements and user-messages. The problem that was described in issue #8.

The problem was caused by the incomplete registration of PENDING messages. As a result messages (and acknowledgements) were not picked up by the OutboxCollector process. The changes proposed here will complete all registrations of PENDING messages in a way that the OutboxCollector process will pick them and thereby the messages are actually re-send.

base2bot commented 5 years ago

Can one of the admins verify this patch?

aaronwalker commented 5 years ago

Fix for #8 LGTM will do some additional QA but should able to merge this in the next week or so

cavycorp commented 5 years ago

@aaronwalker did you have time to look at the changes? Do you have any questions concerning these changes?

Thanks,

Hans

aaronwalker commented 5 years ago

@cavycorp happy to merge but is it possible that you can squash these changes into a single commit

cavycorp commented 5 years ago

@aaronwalker , I agree, I will close this Pull Request and make new one.