search

jentrata / jentrata-msh

Jentrata - Message Handler Service
jentrara.org
Other
19 stars 57 forks source link

Remove DuplicateElimination from Acknowledgement #62

Closed cavycorp closed 5 years ago

cavycorp commented 5 years ago

In the ebMS 2.0 standard it is not allowed to have a DuplicateElimination indicator in the Acknowledgement message. This change will update the method generateAcknowledgment by removing the lines that will add the DuplicateElimination indicator.

cavycorp commented 5 years ago

@aaronwalker, do you have questions, doubts or comments concerning the change I propose?

aaronwalker commented 5 years ago

No the changes are all good... Is it possible split the changes for #62 and #63 into seperate PRs since now they are all combined in PR #64

cavycorp commented 5 years ago

@aaronwalker I don't understand how this happend, I did make the split with #62 and #63 and I see they we're added with #64 and #65 but they are still separate aren't they? I mean #64 only contains the change for #62 and #65 only contains the changes for #63.

aaronwalker commented 5 years ago

@cavycorp it's best to make PR from a branch other than master. Basically when you pushed the message Id change to your master branch it get automatically included in any open PR

cavycorp commented 5 years ago

@aaronwalker but I made the changes on different forks, so I forked jentrata/jentrata-msh made changes for #62 did the pull-request. Then deleted my repository did another fork of jentrata/jentrata-msh, so without the #62 changes and made the changes for #63 and did the pull request. As far as I can see the changes are separate from each other.

cavycorp commented 5 years ago

@aaronwalker, I will close both pull request and will redo them separately from different branches.

cavycorp commented 5 years ago

@aaronwalker, I reworked the changes and made two pull requests each from a separate branch from my repository.

cavycorp commented 5 years ago

@aaronwalker, do you agree with these changes?

cavycorp commented 5 years ago

@aaronwalker can you please accept and merge them into the master of Jentrata-MSH?

aaronwalker commented 5 years ago

merged #66 closing