Bugs bugs bugs - Githubissues

jepegit / cellpy

extract and tweak data from electrochemical tests of cells

MIT License

88 stars 30 forks source link

Bugs bugs bugs #265

Closed jepegit closed 11 months ago

jepegit commented 1 year ago

os.getlogin() (used by cellpy new) does not work on linux RHEL cookiecutter is not part of requirements - needed for cellpy new jinja2_time is not part of requirements - needed for cellpy new

jepegit commented 1 year ago

Also need pytables (unfortunately I think pytables can only be installed using conda)

jepegit commented 1 year ago

also need to fix the conda package

should not use py 3.12
should only include needed packages and make another with everything

jepegit commented 1 year ago

Actually - pytables can be installed by pip (python -m pip install tables). But it uses the HDF5 library. And this also needs to be available on the machine. And the HDF5 library is not a python library. Hmm...

jepegit commented 1 year ago

Decided to try to put (py)tables as required in the setup file. And added github actions for installing using pip and running cellpy setup. Only missing fix now is to fix the conda packages (not use py3.12 and either make one cellpy_core and one full cellpy with jupyter etc, or make cellpy with only the absolutely required packages (like for pip) and possibly make a conda package with cellpy+everything else (for example call it cellpy_suite, if conda does not allow for the same as pip where you can add [full] after the name (will check now))

jepegit commented 11 months ago

Seems to work. Closing for now. Probably better to make new issues a bit more "to-the-point"