jepegit / cellpy

extract and tweak data from electrochemical tests of cells
MIT License
88 stars 30 forks source link

Minor revisions for the JOSS manuscript #278

Closed ma-sadeghi closed 8 months ago

ma-sadeghi commented 9 months ago

The paper is well-written, just needs a few minor edits. Here's the list of errors. The list was generated by ChatGPT, which I've manually reviewed and removed those that didn't seem reasonable.

ma-sadeghi commented 9 months ago

Hi @juliawind, thanks for addressing the issues. I just found another minor revision, but I won't clutter your issue tracker with another issue, so I'll add it here:

In the statement of need section, you've cited galvani, neware_reader, and galv, all of which are limited in their scope (can only process certain formats, etc.). Then, you've cited BEEP:

"BEEP (Battery Evaluation and Early Prediction [@beep]) provides a structured interface for collecting and processing battery test data and exports to text format."

but haven't provided a critiuqe of why BEEP is not good. In fact, the wording is a bit confusing because it implies that BEEP is a universal tool, as opposed to the others. It'd be ideal if you could provide a critique of BEEP so that cellpy is differentiated. Thanks!

ma-sadeghi commented 8 months ago

Hi @juliawind, thanks for addressing the issues. I just found another minor revision, but I won't clutter your issue tracker with another issue, so I'll add it here:

In the statement of need section, you've cited galvani, neware_reader, and galv, all of which are limited in their scope (can only process certain formats, etc.). Then, you've cited BEEP:

"BEEP (Battery Evaluation and Early Prediction [@beep]) provides a structured interface for collecting and processing battery test data and exports to text format."

but haven't provided a critiuqe of why BEEP is not good. In fact, the wording is a bit confusing because it implies that BEEP is a universal tool, as opposed to the others. It'd be ideal if you could provide a critique of BEEP so that cellpy is differentiated. Thanks!

This still seems to not have been addressed.

jepegit commented 8 months ago

Wrote:

"""In addition, the Battery Evaluation and Early Prediction (BEEP) library [@beep] provides an interface for parsing text-based data from several instruments. However, the target audience for this library seems to be machine learning researchers, and the library appears at its current state not to be ideal for in-depth data handling and analysis by battery researchers."""

@juliawind: Sounds OK? Or can it be interpreted as if the library is not a good library? What I tried to convey is that it seems to be not very easy to use if you just want to look and play with single data-sets, but is more useful if you have a large amount of data that you want to extract features from and train using scikit-learn.

beep commented 8 months ago

May I ask not to be mentioned in this issue? (I’ve unsubscribed twice now.) Thank you.

juliawind commented 8 months ago

@jepegit yes, sounds good! Could rephrase a bit to make it sound more positive: """... However, the target audience for BEEP seems to be machine learning researchers, focusing on handling and preparing large datasets, while cellpy provides tools for more in-depth data handling and analysis for battery researchers. """

jepegit commented 8 months ago

Great!

ma-sadeghi commented 8 months ago

Sounds good! Thanks for clarifying!