search

jeppeman / GloballyDynamic

Dynamic Delivery everywhere through a common API
Apache License 2.0
298 stars 18 forks source link

GloballyDynamic not compatible with AGP 8.0.2 #114

Closed FlavioConrado closed 1 year ago

FlavioConrado commented 1 year ago

Description

While trying to update my project to AGP 8.0.2 ('com.android.tools.build:gradle:8.0.2') I saw that I got the following error while trying to build the project: Unable to load class 'com.android.builder.packaging.JarMerger'. If I downgrade it to it's initial version (AGP 7.2.1) the build come back to normal.

Steps to Reproduce

GloballyDynamic gradle plugin version

'com.jeppeman.globallydynamic.gradle:plugin:1.6.0'

GloballyDynamic android library version

'com.jeppeman.globallydynamic.android:selfhosted:1.3.0'

GloballyDynamic android studio plugin version

implementation 'com.jeppeman.globallydynamic.android:selfhosted:1.3.0'

Android Studio Version

Android Studio Flamingo | 2022.2.1 Patch 2

Link to a public git repo demonstrating the problem:

FlavioConrado commented 1 year ago

After downloading the globallydynamic gradle plugin, I saw that the class JarMerger is missing on version 8.0.2 of gradle: image

FlavioConrado commented 1 year ago

Found that the JarMerger were moved to JarFlinger.

jeppeman commented 1 year ago

Hey @FlavioConrado, thanks for reporting. Will take a look as soon as I have some time to spare; probably tomorrow.

FlavioConrado commented 1 year ago

I made some changes that made it work with AGP 8, you could you as base for what need to be changed.

FlavioConrado commented 1 year ago

globally_dynamic_patch.zip

jeppeman commented 1 year ago

globally_dynamic_patch.zip

Thanks! I've made the changes now, will publish during the day. I'll keep you posted.

jeppeman commented 1 year ago

Hey @FlavioConrado, sorry for the wait, but version 1.7.0 of the gradle plugin has been published now.

FlavioConrado commented 1 year ago

Thanks @jeppeman!