search

jepsen-io / jepsen

A framework for distributed systems verification, with fault injection
6.69k stars 710 forks source link

Stevana/clock targets #456

Closed stevana closed 4 years ago

stevana commented 4 years ago

Second try. Changes since last time:

I tried testing the code on the etcd repo using lein checkouts, but etcd doesn't compile anymore because some stuff in tests.cycle have been moved to elle?

Also sorry about the whitespace changes, I have the habit of hitting SPC m = and having CIDER reformat the buffer and it doesn't seem to agree with your formatting style (I thought in Lisp-land code formatting was as solved problem?). Or do you use a different formatter/settings? I'm happy to revert it if it annoys you?

aphyr commented 4 years ago

Yeah, I'd prefer this without the whitespace changes--I work hard on keeping a consistent formatting style! Mostly that's vim-fireplace, but there are a few places (e.g. namespace imports) where I align manually for clarity.

aphyr commented 4 years ago

Other than the whitespace, I'd say this looks good to go. Migrating etcd forward shouldn't be a huuuge problem--most of the APIs are the same, just with different namespace names. I've got client work that I gotta tackle before I can head over and fix that unfortunately. :(

aphyr commented 4 years ago

Wooo!