search

jepsen-io / jepsen

A framework for distributed systems verification, with fault injection
6.78k stars 714 forks source link

jepsen.store.FressianReader: add type parameters to resolve compiler warnings #558

Closed nurturenature closed 1 year ago

nurturenature commented 1 year ago

Add type parameters to jepsen.store.FressianReader to resolve compiler warnings as discussed in #557.

The type annotations needed seemed straightforward.

-Xlint:unchecked compiles clean.

lein test is 100%.

And a local test runs fine with the changes.

The changes were made not so much from understanding, as from looking at examples and IDE language plugin squiggles. So feel free to say it needs work.

aphyr commented 1 year ago

I'll take it! Might want to shoot this upstream to Fressian too. :-)

aphyr commented 1 year ago

BTW, @nurturenature, there are some pretty big performance-oriented changes coming in this version of Jepsen. I'm hopeful that makes everyone's lives better, but if you notice anything breaking let me know!

Come to think of it, if you notice things are improved, I wouldn't mind hearing about that too. ;-)