search

jepsen-io / jepsen

A framework for distributed systems verification, with fault injection
6.84k stars 718 forks source link

jepsen.control.sshj: catch agent-not-found exceptions and continue trying other auth methods #591

Closed markbradley27 closed 6 months ago

markbradley27 commented 6 months ago

The auth! method tries a few different approaches for authenticating, the second of which is via an ssh-agent. If the agent is found but not able to authenticate, that exception is caught so it can move on to trying other authentication methods. However if no agent is found, that exception is not caught, meaning we return early without trying subsequent methods.

This PR adds a catch for the agent-not-found exception as well so we move on to other auth methods, which should resolve #547.

aphyr commented 6 months ago

Oooh, good detective work! Thank you. :-)