jepser / typeform

WordPress plugin for Typeform
4 stars 2 forks source link

This plugin breaks when Yoast SEO and Classic Editor are installed #9

Open robbertrosario opened 5 years ago

robbertrosario commented 5 years ago

The plugin works with just Gutenberg and the Classic Editor installed; however when you enable Yoast SEO you get the following error:

Loading failed for the <script> with source “http://mydomain.dev/wp-content/plugins/typeform/assets/js/themes/modern/theme.js?wp-mce-6000-20180716”

That file doesn't exist, and it actually should be loaded from the wp-includes folder.

Likewise when Typeform is disabled but Yoast SEO and Classic Editor are enabled it also works; the same script as above is loaded but this time from the correct location:

wp-includes/js/tinymce/themes/modern/theme.js?wp-mce-6000-20180716

I suspect this happens because both plugins are using & extending the tinymce plugin.

Looks like more people are having these problems when you look at the WP support board of this plugin: https://wordpress.org/support/topic/editor-breaks-due-to-javascript-error-on-wp-5-0/

patrick-russell commented 5 years ago

Experiencing the same issue as described above.

Wordpress 5.1.1 Classic editor v1.4 Yoast: v11.1 Typeform v 0.7.5 I also tried v 0.8.0 by downloading the zip from this repo and installing by hand. Same result.

Typeform with Classic Editor works fine.

Yoast with Classic Editor works fine.

Enabling Typeform and Yoast leads to a broken editor.

Seeing this in the devtools console when attempting to switch from visual to text mode in the editor.

This js file is throwing a 404: wp-content/plugins/typeform/assets/js/themes/modern/theme.js?wp-mce-4920-20181217-tadv-5.0.0

VM6922 editor.min.js:1 Uncaught TypeError: Cannot read property 'getSelection' of undefined at q (VM6922 editor.min.js:1) at e (VM6922 editor.min.js:1) at HTMLDocument.<anonymous> (VM6922 editor.min.js:1) at C (VM6820 tinymce.min.js:2) at HTMLDocument.d (VM6820 tinymce.min.js:2)

E-VANCE commented 5 years ago

Experienced the same issues, fixed now with the latest updates: