search

jepusto / lmeInfo

Information matrices for fitted nlme::lme and nlme::gls models
https://jepusto.github.io/lmeInfo/
4 stars 2 forks source link

Separate variance estimates #41

Closed manchen07 closed 2 years ago

manchen07 commented 2 years ago

Could you look over the code and let me know whether it makes sense?

Shall we also work on the bug with star models. Otherwise, all checks fail.

manchen07 commented 2 years ago

This all looks great. Please see the few changes I pushed that simplify the condition checking in extract_varcomp(). I think they'll be relevant for Fisher_info() too.

Based on our conversation, I think the outstanding pieces here are

  • Simplifying the Jacobean calculations
  • Providing a separate_variances option in g_mlm().

I've finished updating the code regarding those two outstanding pieces and added relevant unit tests. Please let me know if the Jacobian calculations are wrong or if further changes are needed.