search

jepusto / lmeInfo

Information matrices for fitted nlme::lme and nlme::gls models
https://jepusto.github.io/lmeInfo/
4 stars 2 forks source link

Doesn't install on R 4.0.x #46

Closed rogerssam closed 2 years ago

rogerssam commented 2 years ago

Hello, I'm just wondering if you could explain why the package depends on R >= 4.1? I am the developer of the package biometryassist. It turns out that your package is a cascaded dependency from another package that biometryassist imports. I understand the complications with dependencies and R versions, but would it be possible for you to re-add for support for R4.0? Many thanks, Sam

jepusto commented 2 years ago

R 4.1 introduced the native pipe (|>), which we use in some of our tests. I can consider reworking the tests so that we don't use pipes. Could you provide some more information about your need to support R < 4.1?

rogerssam commented 2 years ago

Many thanks for your response. That makes sense. I have cloned the repo and reworked the test file with pipes, and confirmed the tests still pass on R 4.0.0.

The problem that I encounter is people who are hesitant to update R + packages because it can be fragile, especially for novice users. So I try to aim to support a few of the most recent versions to give people at least a couple of years of stability.

Would you accept a pull request for this? I am happy to submit one next week to close this issue if that's ok with you?

jepusto commented 2 years ago

Yes, happy to take a PR. However, we just submitted an update to lmeInfo on 7/7, so I want to wait another few weeks (until 8/7 at least) before sending another submission to CRAN. Just to set expectations.

rogerssam commented 2 years ago

Great, thanks again. I completely understand re submitting to CRAN.