jerabaul29 / OpenMetBuoy-v2021a

An easy to build, affordable, customizable, open source instrument for oceanographic measurements - with global Iridium coverage
MIT License
37 stars 7 forks source link

adding criteria to push to buffer when there is no wave signal (for large number of OMBs on fast ice to cut Iridium cost). #89

Closed tnn77 closed 8 months ago

tnn77 commented 8 months ago

@jerabaul29 Hi, Jean.

We are not sure whether we implement this or not, but as discussed, we would like to have this as an option. The idea to have a push criteria was suggested by Tsubasa. For now, we simply use Hs and likely a value around 1 cm. The sensor spec noise is about 0.4 cm, we achieved 0.5 cm in NABOS and 0.8 cm in JARE63 (the Antarctica 2022 deployment). So I think 1 cm may be a good start.

I think the added lines of the code is straight forward, but if you can check/have suggestions, please let me know. Thanks so much.

https://github.com/tnn77/OpenMetBuoy-v2021a/blob/85db725043142f9071fa8df4f77205153f3e6669/legacy_firmware/firmware/jare65/wave_analyzer.cpp#L265-L270

jerabaul29 commented 8 months ago

Many thanks for the update on this @tnn77 :) . That does look very good, I agree this is likely the best way to implement this :) . Just being curious, have you done a check / test (just to make sure things are triple checked :) )? You could for example i) put a buoy on a flat stable surface and check that you get no wave message, ii) move the buoy by hand or put it at sea or on some moving support and check that you get wave messages. I think the change is so simple that this is not absolutely necessary, but always best to test if there is the possibility, this is a good habit to have :) .

tnn77 commented 8 months ago

@jerabaul29 thanks for taking a look! the sensors are on the ship already, but I am doing work there this week, so I will test this out and let you know.

tnn77 commented 8 months ago

I was able to compile and test (on the ship, so it was not practical to get a very small signal, so I tested with 0.05 m, it worked). when I had it set at 0.008 m, I think ship vibration, even docked produced 0.02 m Hsig).

Anyway, I think we are all good, Thank you so much.

jerabaul29 commented 8 months ago

Amazing, many thanks for the update and good cruise :) .