search

jerakia / jerakia-ansible-lookup-plugin

An Ansible lookup plugin for integrating with Jerakia
Other
11 stars 9 forks source link

Fix Python 3 compatibility #4

Open jqueuniet opened 5 years ago

jqueuniet commented 5 years ago

I tried to use this plugin with Python 3 and had to fix a few minor incompatibilities to make it work.

The items() call does return a copy instead of a generator in Python 2, but I think that's a fair compromise as the configuration is very unlikely to be large enough to cause a performance issue.

The dictionary merge could be written as {**dict1, **dict2} from Python 3.5 onward, which probably wouldn't be too much of a stretch as prerequisite as this point, but this would also break Python 2 compatibility.

jqueuniet commented 5 years ago

I should mention this was tested with Python 3.7.3rc1 and Ansible dev.

vincentbernat commented 4 years ago

Any change for this to get merged? Python 2 is EOL and we have switched everything to Python 3 on our side. Thanks.