Comments & units in TCL file

[jerbaroo]

• [ ] Sort and add comment to uniaxialMaterial Elastic
• [ ] Sort and add comment to element zeroLength

[rozsasarpi]

Units

They make sense. Although I would surely not have different units within the same project (Python and Tcl). Moreover, I would use only SI base units and make a statement that all derived units are built up using the SI base units, no prefixes. For example stress would be N/m^2 = Pa. I think this requires the least amount of information to retain in my head about the unit system, hence for me this would be the least error prone.

[rozsasarpi]

Comments in TCL file

• I find the tcl file that is generated by gidopensees exemplary. You could take inspiration from them, e.g. adding tabs to make the columns more readable and adding metadata at the end of the file. See the attached zip.
• You write in the header the dimensions are in meter and forces are in N. Since nothing else is mentioned there, from this I would confidently assume that all derived units are made up of these. However, this is not the case as you wrote that Young's modulus is in TPa.
• Maybe change # Begin support nodes to # Begin pier nodes.
• I cannot decipher what these mean: # support 22nd wall 1st z 4 y 2nd, if it is not only for guiding you in the development then it might be a good idea to make it understandable.
• Similarly here # support 5 z 4, though I besides the z I think I know what you had in mind.
• In ShellMITC4: the unit of density in the comment is incorrect kg/m
• Is there a reason that the comments after the ShellMITC4 for the piers are different? I was expecting the same helping comments as for the deck.

Tutorial - Masonry Structure with Concrete Slab.zip

[jerbaroo]

That's great feedback, thanks!!

[jerbaroo]

Keeping track of a few things that should be cleaned up in the top comment, added two things regarding the current WIP PR #188