search

jerber / MagicDB

MIT License
3 stars 1 forks source link

consider rename parameter `fromfile` since it accept both file path and dictionary #1

Open wasdee opened 4 years ago

wasdee commented 4 years ago

https://github.com/jerber/MagicDB/blob/7ae33fec62ab3af44688e29b29d669f756c196c8/src/magicdb/database/Database.py#L10-L22

the firebase 

credentials.Certificate(from_file)

from_file could be either file path or dict

jerber commented 4 years ago

Good point, I'll rename it in the next version.