search

jerel / ember-cli-growl

A growl notification system for EmberJS packaged as an Ember CLI add-on.
MIT License
20 stars 8 forks source link

Fix depreciation warning #6

Closed jniechcial closed 9 years ago

jniechcial commented 9 years ago

There is opened issue but looks like it's dead already.

jerel commented 9 years ago

Thanks for the PR. Looks like we'll have to upgrade Ember CLI to get tests passing again. I'll try to get to it but it might be a few days yet. If you (or anyone) else wants to tackle it I'm happy to review and merge.

jniechcial commented 9 years ago

@jerel I upgraded ember-cli, ember and couple of other packages and fix the tests. I am not very content with your current acceptance test suite - you should take care of acceptance helpers (like click, etc.) but I am aware that they wrap the execution in andThen. Basically, it's useless as the addon wraps the run loop until the message disappear so the element won't be found.

For now, I think that this quick win is enough. Give me a sign what you think.

jerel commented 9 years ago

@jniechcial thanks a bunch for doing this upgrade!

jniechcial commented 9 years ago

No problem, thanks! Waiting for release ;)

jerel commented 9 years ago

Boom: https://www.npmjs.com/package/ember-cli-growl

jniechcial commented 9 years ago

Thanks, pleasure! :)