search

jerel / ember-cli-loading-slider

A YouTube like loading indicator for EmberJS packaged as an Ember CLI add-on.
MIT License
116 stars 36 forks source link

Fix for expanding animation on IE. #18

Closed tushar-chauhan closed 8 years ago

tushar-chauhan commented 8 years ago

This fixes the width of loading animation on versions of IE > 9. Before the margin-left was moving it on the left half of the screen so the animation was not happening for full width but just within left half of the screen on the top. I hope it helps.

tushar-chauhan commented 8 years ago

Please review this pull request when you get time. We are using your module in our project and we have to support IE versions > 10. It will help us, if you review this sooner.

jerel commented 8 years ago

Thanks for this, however I want to avoid user agent detection. There's surely a cross-browser way to achieve the same thing?

tushar-chauhan commented 8 years ago

I am really not sure how to segregate IE from rest of the browsers without catching the user agent. I have tested this fix though for working in IE 10 & 11. this makes sure that the animation expands to full width in IE. Chrome and other browsers works fine with the default inline CSS which is already there, so I didn't change anything there.

I tried a lot of CSS combinations too to make the animation on IE look like as they are in other browsers and this is the only change that made the animation look a bit decent on IE. If you have any suggestions to check for IE without user agent detection and you can direct me, then it will be helpful.

jerel commented 8 years ago

@tushar-chauhan thanks for the PR. Check out v1.2.1