search

jerel / ember-cli-loading-slider

A YouTube like loading indicator for EmberJS packaged as an Ember CLI add-on.
MIT License
116 stars 36 forks source link

Convert to using a service that triggers events for component #19

Closed dasnixon closed 8 years ago

dasnixon commented 8 years ago

Since Ember is moving away from using controllers, having a service that can broadcast events you can listen to from anywhere seems useful.

@jerel let me know what you think, I can update the README with the updated functionality if we think this is worth it. Just me playing around, a super cool library nonetheless!

jerel commented 8 years ago

@dasnixon I like this direction. Lots of different types of code may want to trigger the slider (such as a nested component that uses the store).

One thing I noticed, it appears that the ability to set speed, color, etc via the component attributes was removed? I believe it'd be best to keep that for backwards compatibility and template usage.

dasnixon commented 8 years ago

@jerel I'll re-add that functionality back to make it backwards compatible. Probably get to it on Friday.

jerel commented 8 years ago

@dasnixon ping :-)

dasnixon commented 8 years ago

@jerel sorry got a little busy, will get to this soon though.

dasnixon commented 8 years ago

@jerel updated, let me know if it looks good.

dasnixon commented 8 years ago

ping @jerel

jerel commented 8 years ago

@dasnixon thanks so much for this contribution!