jerel / ember-cli-loading-slider

A YouTube like loading indicator for EmberJS packaged as an Ember CLI add-on.
MIT License
116 stars 36 forks source link

Documentation: expanded should be a boolean instead of a string #7

Closed Bargs closed 9 years ago

Bargs commented 9 years ago

The current readme shows the following code for adding an expanding slider to your template:

{{loading-slider isLoading=loading expanding="true" color=hexColorsArray}}

Because the expanding property is listed in classNameBindings, the component's element is given a class matching the string value of this property: true.

To get a class value of expanding as expected, I had to pass expanding's value as a boolean instead of a string:

{{loading-slider isLoading=loading expanding=true color=hexColorsArray}}

Using Ember 1.10.0