jereldlimjy / pe

0 stars 0 forks source link

Cannot edit the customer of an order #7

Open jereldlimjy opened 1 year ago

jereldlimjy commented 1 year ago

If I accidentally add an order to the wrong customer, the edito command does not allow me to change the customer of that order (I'll need to delete order, and add again).

Since edito already allows for changing the name/quantity/address of an order, changing the corresponding customer should be a natural feature as well

Screenshot 2023-04-14 at 2.54.04 PM.png

nus-se-bot commented 1 year ago

Team's Response

We reject this issue because we do not believe there should be a case where an order should be reassigned to another customer. Once an order has been made by a customer, it does not make sense that the order should 'belong' to another customer at any point of time.

Another perspective is for accountability. If another customer wants to make the same order, they will have to submit a new order. We should leave the old order there and possibly 'cancel' the order.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Even though an order is made by a customer, the order itself is added by the user of LoyaltyLift, this means that errors can occur - e.g. mistakenly adding an order to a wrong customer. Since edito already allows for the editing of name/quantity/address of an order, I believe that the option to edit the customer should be a natural extension, and a trivial one, and not having it would be a feature flaw.