jeremeamia / xstatic

Static Proxies (like Laravel "Facades") in any PHP project
MIT License
104 stars 6 forks source link

Documentation incorrect #2

Closed pherrymason closed 9 years ago

pherrymason commented 9 years ago

There is a little error in documentation regarding the implementation of StaticProxies:

class Pdo extends StaticProxy
    {
        public function getInstanceIdentifier()
        {
            return 'db';
        }
    }

Should be:

class Pdo extends StaticProxy
    {
        public static function getInstanceIdentifier()
        {
            return 'db';
        }
    }
jeremeamia commented 9 years ago

Good catch. Same with the Twig one underneath. Do you want to submit a PR? It's an easy change for me to make, of course, but I'm just wondering if you want the geek cred. :sunglasses:

pherrymason commented 9 years ago

Haha, sure why not