search

jeremenichelli / hunt

👻 Minimal library to observe nodes entering and leaving the viewport
https://jeremenichelli.github.io/hunt
MIT License
342 stars 10 forks source link

IE9-11 #9

Closed kilianf closed 8 years ago

kilianf commented 8 years ago

Hey Jeremias -

You did a great job with this plugin, and I think it's the best out there for scroll detection. I've built out my site using it, and started testing, and that's when I ran into an issue in IE. The issue is that on Chrome, Safari, Firefox, when an element comes into view at the bottom it fires properly, but on IE 9-11 on Windows 7, it only fires when the element hits the top of the viewport (when it's about to go out of view). I've tested it with your demo page as well as mine, and I get the same behavior.

Any updates you might have would be greatly appreciated!

jeremenichelli commented 8 years ago

Thanks for reporting this @kilianf! As soon as I can run some test in a Windows machine I'll come back with some feedback.

jeremenichelli commented 8 years ago

@kilianf bug detected :bug: will work on a fix over the weekend!

kilianf commented 8 years ago

That's great to hear, I really appreciate your work on this!

jeremenichelli commented 8 years ago

@kilianf, good news for you, there's a new version with all this problem solved. Please confirm that you're not experiencing this issue anymore so I feel sure this can be closed.

Note: Take in count test pages won't work in IE9 since they use classList which is not supported there, but if you're code is IE9 compatible with this new hunt version you should have no errors.

kilianf commented 8 years ago

Thanks @jeremenichelli - this works perfect, and thanks again for the quick response! It saved a ton of time on a big project.

jeremenichelli commented 8 years ago

More than happy to read that, feel free to share your project using hunt when is ready!

kilianf commented 8 years ago

Just made the page live - http://www.uw.edu/boundless/alternative-spring-break Hunt helped so much with dynamically loading the videos at the bottom, and with firing the animations!

jeremenichelli commented 8 years ago

Wow! Awesome @kilianf! Beautiful site and great use case for the script. Thanks a lot for sharing!