Closed alonbl closed 10 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
941a661
) 96.03% compared to head (20378c3
) 96.03%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Morning @alonbl ,
I feel the documentation for pre-commit
should be moved from the usage page to it's own page. I worry people could miss this integration opportunity. I can't decide exactly where it would go.
So at the top level there are the following sections:
pre-commit
is neither a CI server or an editor. The second makes sense as it is very generic, however, pre-commit
is a specific tool and the options listed under Tool Integration do not apply. I suppose we could split the section into specific tools and then generic tools.So something like this:
Then we could go into more detail on how to properly integrate VSG with pre-commit
and better communicates the integration option.
What do you think?
--Jeremy
OK, moved documentation to own page, in most cases people who use pre-commit understand how to use the plugins, I do not think we should be so verbose.
Morning @alonbl ,
Looks good.
--Jeremy
Hi @jeremiah-c-leary, I added another example for the pre-commit configuration. Alon
Closed via #1017
Description
pre-commit is a tool for running various of format and validation tools. It would be nice if it will be possible to use vsg as pre-commit hook.
Additional context
Trivial changes provided as a patch set:
Tested and working for me, please let me know what you think.