Closed alonbl closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
a35ff96
) 95.87% compared to head (f7fe83c
) 95.87%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Morning @alonbl ,
I can not think of any reason not to use a temp file and then copy it over.
So I imagine this pull request will be closed when we close #1017 , correct?
--Jeremy
Morning @alonbl ,
I can not think of any reason not to use a temp file and then copy it over.
It is atomic move not copy, so either you have the new or the old.
So I imagine this pull request will be closed when we close #1017 , correct?
Correct, it is included in the combined patchset.
Closed via #1017
Description Do not overwrite file as we may corrupt the file if something fails, instead write into temporary location and move the result into the final destination.