jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
182 stars 38 forks source link

Use platform independent file name in configuration #1015

Closed alonbl closed 11 months ago

alonbl commented 11 months ago

Description

Current implementation searches the file as provided by user or glob, this name may be platform specific.

New implementation will always use '/' as separator, enabling the same configuration to be used in any platform.

alonbl commented 11 months ago

sorry, the import os was dropped during my rebase.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (57e7f8b) 95.87% compared to head (d8f0ad6) 95.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1015 +/- ## ======================================= Coverage 95.87% 95.87% ======================================= Files 1500 1500 Lines 28262 28264 +2 ======================================= + Hits 27095 27097 +2 Misses 1167 1167 ``` | [Files](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1015?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary) | Coverage Δ | | |---|---|---| | [vsg/apply\_rules.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1015?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL2FwcGx5X3J1bGVzLnB5) | `88.23% <100.00%> (+0.23%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jeremiah-c-leary commented 11 months ago

Morning @alonbl,

Thanks for the pull request. I appreciate the improved portability this PR provides.

--Jeremy