jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
182 stars 38 forks source link

alonbl patch series #1017

Closed alonbl closed 10 months ago

alonbl commented 11 months ago

Rebased series as many of these conflicts, will keep this up-to-date with the other pull requests.

Description Pull Request
Add pre-commit hooks support https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1011
Support shallow git clone without tags https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1011
Support files as positional argument https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1011
Synchronize README command-line usage https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1011
Use platform independent file name in configuration https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1015
Support file configuration without scanning the file https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1016
Add linesep configuration option https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1012
Perform atomic write to files https://github.com/jeremiah-c-leary/vhdl-style-guide/pull/1014
codecov[bot] commented 11 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (941a661) 96.03% compared to head (9615eab) 96.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1017 +/- ## ========================================== + Coverage 96.03% 96.06% +0.02% ========================================== Files 1512 1512 Lines 28575 28579 +4 ========================================== + Hits 27442 27454 +12 + Misses 1133 1125 -8 ``` | [Files](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary) | Coverage Δ | | |---|---|---| | [vsg/apply\_rules.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL2FwcGx5X3J1bGVzLnB5) | `89.74% <100.00%> (+0.55%)` | :arrow_up: | | [vsg/cmd\_line\_args.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL2NtZF9saW5lX2FyZ3MucHk=) | `93.68% <100.00%> (+0.06%)` | :arrow_up: | | [vsg/vhdlFile/utils.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3ZoZGxGaWxlL3V0aWxzLnB5) | `86.03% <87.50%> (+1.17%)` | :arrow_up: | | [vsg/version.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3ZlcnNpb24ucHk=) | `20.00% <0.00%> (-0.41%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alonbl commented 11 months ago

Fixing coverage

jeremiah-c-leary commented 10 months ago

Morning @alonbl ,

I was going to start merging these pull requests in, but this one has me stumped. Would I just merge this one in or would I merge in the others individually?

--Jeremy

alonbl commented 10 months ago

Hi, Yes, I rebased everything in this patch to make it easier for merge and push each functionality to be reviewed as github does not support per patch review. If everything is good, you can just merge this one. Thanks,

alonbl commented 10 months ago

Rebased.

jeremiah-c-leary commented 10 months ago

Morning @alonbl ,

I am going to merge this pull request in.

Thanks for contributions.

--Jeremy

alonbl commented 10 months ago

Hi, I just added one more example for the pre-commit in the documentation, please have a look before merging. Thanks!

jeremiah-c-leary commented 10 months ago

I updated and see the changes. It looks good.

Anything else before I merge?

--Jeremy

alonbl commented 10 months ago

I updated and see the changes. It looks good.

Thanks!

Anything else before I merge?

Nope, please go ahead.

alonbl commented 10 months ago

@jeremiah-c-leary, thank you so much, waiting to a new release as pre-commit will not work with master as a reference.

jeremiah-c-leary commented 10 months ago

Release 3.18.0 has been completed.

alonbl commented 10 months ago

Release 3.18.0 has been completed.

Thank you, we successfully switched to upstream repository for our build and CI.