Closed alonbl closed 10 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
941a661
) 96.03% compared to head (9615eab
) 96.06%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixing coverage
Morning @alonbl ,
I was going to start merging these pull requests in, but this one has me stumped. Would I just merge this one in or would I merge in the others individually?
--Jeremy
Hi, Yes, I rebased everything in this patch to make it easier for merge and push each functionality to be reviewed as github does not support per patch review. If everything is good, you can just merge this one. Thanks,
Rebased.
Morning @alonbl ,
I am going to merge this pull request in.
Thanks for contributions.
--Jeremy
Hi, I just added one more example for the pre-commit in the documentation, please have a look before merging. Thanks!
I updated and see the changes. It looks good.
Anything else before I merge?
--Jeremy
I updated and see the changes. It looks good.
Thanks!
Anything else before I merge?
Nope, please go ahead.
@jeremiah-c-leary, thank you so much, waiting to a new release as pre-commit will not work with master as a reference.
Release 3.18.0 has been completed.
Release 3.18.0 has been completed.
Thank you, we successfully switched to upstream repository for our build and CI.
Rebased series as many of these conflicts, will keep this up-to-date with the other pull requests.